From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Date: Tue, 13 Oct 2015 12:27:33 +0000 Subject: Re: [patch] ASoC: wm8731: harmless underflow in wm8731_put_deemph() Message-Id: <20151013122733.GG8805@ck-lbox> List-Id: References: <20151013070857.GC31537@mwanda> In-Reply-To: <20151013070857.GC31537@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , Fabio Estevam , Songjun Wu , Krzysztof Kozlowski , Axel Lin , Sergey Kiselev , patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org On Tue, Oct 13, 2015 at 10:08:57AM +0300, Dan Carpenter wrote: > The code tries to verify that "deemph" is zero or one, but it fails to > account for that it can be negative. It's harmless because negatives > are treated the same as one, but we should fix it just to silence the > static checker warning. > > Signed-off-by: Dan Carpenter Acked-by: Charles Keepax Thanks, Charles