* [patch] ASoC: wm8903: harmless underflow in wm8903_put_deemph()
@ 2015-10-13 7:10 Dan Carpenter
2015-10-13 12:28 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-10-13 7:10 UTC (permalink / raw)
To: Liam Girdwood
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Charles Keepax,
Lars-Peter Clausen, Mauro Carvalho Chehab, Tomi Valkeinen,
Axel Lin, Krzysztof Kozlowski, abdoulaye berthe, patches,
alsa-devel, kernel-janitors
Valid values for "deemph" are zero and one, but we accidentally allow
negative values as well. It's harmless, but static checkers complain
and we may as well clean it up.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c
index b011253..e4cc41e 100644
--- a/sound/soc/codecs/wm8903.c
+++ b/sound/soc/codecs/wm8903.c
@@ -452,7 +452,7 @@ static int wm8903_put_deemph(struct snd_kcontrol *kcontrol,
{
struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
- int deemph = ucontrol->value.integer.value[0];
+ unsigned int deemph = ucontrol->value.integer.value[0];
int ret = 0;
if (deemph > 1)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] ASoC: wm8903: harmless underflow in wm8903_put_deemph()
2015-10-13 7:10 [patch] ASoC: wm8903: harmless underflow in wm8903_put_deemph() Dan Carpenter
@ 2015-10-13 12:28 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2015-10-13 12:28 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Lars-Peter Clausen, Mauro Carvalho Chehab, Tomi Valkeinen,
Axel Lin, Krzysztof Kozlowski, abdoulaye berthe, patches,
alsa-devel, kernel-janitors
On Tue, Oct 13, 2015 at 10:10:18AM +0300, Dan Carpenter wrote:
> Valid values for "deemph" are zero and one, but we accidentally allow
> negative values as well. It's harmless, but static checkers complain
> and we may as well clean it up.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-13 12:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 7:10 [patch] ASoC: wm8903: harmless underflow in wm8903_put_deemph() Dan Carpenter
2015-10-13 12:28 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).