From: Dan Carpenter <dan.carpenter@oracle.com>
To: Clemens Ladisch <clemens@ladisch.de>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: [patch] ALSA: firewire-tascam: off by one in identify_model()
Date: Thu, 15 Oct 2015 18:18:29 +0000 [thread overview]
Message-ID: <20151015181828.GC3163@mwanda> (raw)
In the original code, we potentially put a NUL character in model[8] and
it caused a static checker warning. We can put the NUL in model[7]
instead.
Fixes: 53b3ffee7885 ('ALSA: firewire-tascam: change device probing processing')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/firewire/tascam/tascam.c b/sound/firewire/tascam/tascam.c
index c6747a4..6ef2bcc 100644
--- a/sound/firewire/tascam/tascam.c
+++ b/sound/firewire/tascam/tascam.c
@@ -51,7 +51,7 @@ static int identify_model(struct snd_tscm *tscm)
}
/* Pick up model name from certain addresses. */
- for (i = 0; i < 8; i++) {
+ for (i = 0; i < 7; i++) {
c = config_rom[28 + i / 4] >> (24 - 8 * (i % 4));
if (c = '\0')
break;
next reply other threads:[~2015-10-15 18:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 18:18 Dan Carpenter [this message]
2015-10-17 10:11 ` [patch] ALSA: firewire-tascam: off by one in identify_model() Takashi Iwai
2015-10-17 12:02 ` Dan Carpenter
2015-10-18 1:00 ` Takashi Sakamoto
2015-10-19 11:29 ` [patch v2] " Dan Carpenter
2015-10-19 11:54 ` Takashi Sakamoto
2015-10-19 12:01 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015181828.GC3163@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox