From: Lee Jones <lee.jones@linaro.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] mfd: arizona: signedness bug in arizona_runtime_suspend()
Date: Mon, 19 Oct 2015 15:18:13 +0000 [thread overview]
Message-ID: <20151019151813.GJ31804@x1> (raw)
In-Reply-To: <20151019101805.GE26688@mwanda>
export fullname=drivers/mfd/arizona-core.c
# From Dan's script
git log --oneline --no-merges mainline/master -- $fullname | head -n 10
3762aed mfd: arizona: Fixup some formatting/white space errors
6887b04 mfd: arizona: Add support for WM8998 and WM1814
16f6a0d mfd: arizona: Fix race between runtime suspend and IRQs
72e4316 mfd: arizona: Fix initialisation of the PM runtime
1115092 mfd: arizona: Fix race between runtime suspend and IRQs
8019ff6 regmap: Use reg_sequence for multi_reg_write / register_patch
fc027d1 mfd: arizona: Split INx_MODE into two fields
121c075 mfd: wm5110: Add delay before releasing reset line
e6cb734 mfd: arizona: Add better support for system suspend
96129a0 mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode
Each of the $subject lines above start with a capital letter. ;)
On Mon, 19 Oct 2015, Dan Carpenter wrote:
> The "jd_active" variable needs to be signed for the error handling to
> work.
>
> Fixes: 143e5887ae57 ('mfd: arizona: factor out checking of jack detection state')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 4e49210..d474732 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -628,7 +628,7 @@ err:
> static int arizona_runtime_suspend(struct device *dev)
> {
> struct arizona *arizona = dev_get_drvdata(dev);
> - unsigned int jd_active = 0;
> + int jd_active = 0;
> int ret;
>
> dev_dbg(arizona->dev, "Entering AoD mode\n");
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-10-19 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 10:18 [patch] mfd: arizona: signedness bug in arizona_runtime_suspend() Dan Carpenter
2015-10-19 10:19 ` Charles Keepax
2015-10-19 15:18 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151019151813.GJ31804@x1 \
--to=lee.jones@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox