* [patch] ACPI/CPPC: signedness bug in register_pcc_channel()
@ 2015-10-22 19:52 Dan Carpenter
2015-10-23 8:45 ` Ashwin Chaugule
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2015-10-22 19:52 UTC (permalink / raw)
To: Rafael J. Wysocki, Ashwin Chaugule; +Cc: Len Brown, linux-acpi, kernel-janitors
The "pcc_subspace_idx" is -1 if it hasn't been initialized yet. We need
it to be signed.
Fixes: 337aadff8e45 ('ACPI: Introduce CPU performance controls using CPPC')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
index 0bbf84b..2ed5516 100644
--- a/drivers/acpi/cppc_acpi.c
+++ b/drivers/acpi/cppc_acpi.c
@@ -302,7 +302,7 @@ err_ret:
}
EXPORT_SYMBOL_GPL(acpi_get_psd_map);
-static int register_pcc_channel(unsigned pcc_subspace_idx)
+static int register_pcc_channel(int pcc_subspace_idx)
{
struct acpi_pcct_subspace *cppc_ss;
unsigned int len;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] ACPI/CPPC: signedness bug in register_pcc_channel()
2015-10-22 19:52 [patch] ACPI/CPPC: signedness bug in register_pcc_channel() Dan Carpenter
@ 2015-10-23 8:45 ` Ashwin Chaugule
2015-10-28 2:48 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Ashwin Chaugule @ 2015-10-23 8:45 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Rafael J. Wysocki, Len Brown, linux acpi, kernel-janitors
On 22 October 2015 at 15:52, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The "pcc_subspace_idx" is -1 if it hasn't been initialized yet. We need
> it to be signed.
>
> Fixes: 337aadff8e45 ('ACPI: Introduce CPU performance controls using CPPC')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 0bbf84b..2ed5516 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -302,7 +302,7 @@ err_ret:
> }
> EXPORT_SYMBOL_GPL(acpi_get_psd_map);
>
> -static int register_pcc_channel(unsigned pcc_subspace_idx)
> +static int register_pcc_channel(int pcc_subspace_idx)
> {
> struct acpi_pcct_subspace *cppc_ss;
> unsigned int len;
Acked-by: Ashwin Chaugule <ashwin.chaugule@linaro.org>
Thanks,
Ashwin.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] ACPI/CPPC: signedness bug in register_pcc_channel()
2015-10-23 8:45 ` Ashwin Chaugule
@ 2015-10-28 2:48 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2015-10-28 2:48 UTC (permalink / raw)
To: Ashwin Chaugule; +Cc: Dan Carpenter, Len Brown, linux acpi, kernel-janitors
On Friday, October 23, 2015 04:45:09 AM Ashwin Chaugule wrote:
> On 22 October 2015 at 15:52, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > The "pcc_subspace_idx" is -1 if it hasn't been initialized yet. We need
> > it to be signed.
> >
> > Fixes: 337aadff8e45 ('ACPI: Introduce CPU performance controls using CPPC')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> > index 0bbf84b..2ed5516 100644
> > --- a/drivers/acpi/cppc_acpi.c
> > +++ b/drivers/acpi/cppc_acpi.c
> > @@ -302,7 +302,7 @@ err_ret:
> > }
> > EXPORT_SYMBOL_GPL(acpi_get_psd_map);
> >
> > -static int register_pcc_channel(unsigned pcc_subspace_idx)
> > +static int register_pcc_channel(int pcc_subspace_idx)
> > {
> > struct acpi_pcct_subspace *cppc_ss;
> > unsigned int len;
>
> Acked-by: Ashwin Chaugule <ashwin.chaugule@linaro.org>
Applied, thanks!
Rafael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-28 2:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-22 19:52 [patch] ACPI/CPPC: signedness bug in register_pcc_channel() Dan Carpenter
2015-10-23 8:45 ` Ashwin Chaugule
2015-10-28 2:48 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).