From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: bnxt_en: New Broadcom ethernet driver.
Date: Tue, 03 Nov 2015 14:22:08 +0000 [thread overview]
Message-ID: <20151103142208.GA28545@mwanda> (raw)
Hello Michael Chan,
The patch c0c050c58d84: "bnxt_en: New Broadcom ethernet driver." from
Oct 22, 2015, leads to the following static checker warning:
drivers/net/ethernet/broadcom/bnxt/bnxt.c:5337 bnxt_rx_flow_steer()
warn: impossible condition '(new_fltr->sw_id < 0) => (0-65535 < 0)'
drivers/net/ethernet/broadcom/bnxt/bnxt.c
5335 new_fltr->sw_id = bitmap_find_free_region(bp->ntp_fltr_bmap,
5336 BNXT_NTP_FLTR_MAX_FLTR, 0);
5337 if (new_fltr->sw_id < 0) {
^^^^^^^^^^^^^^^^^^^^
Unsigned never less than zero.
5338 spin_unlock_bh(&bp->ntp_fltr_lock);
5339 rc = -ENOMEM;
5340 goto err_free;
5341 }
regards,
dan carpenter
reply other threads:[~2015-11-03 14:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103142208.GA28545@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).