kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* re: bnxt_en: New Broadcom ethernet driver.
@ 2015-11-03 14:22 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-11-03 14:22 UTC (permalink / raw)
  To: kernel-janitors

Hello Michael Chan,

The patch c0c050c58d84: "bnxt_en: New Broadcom ethernet driver." from
Oct 22, 2015, leads to the following static checker warning:

	drivers/net/ethernet/broadcom/bnxt/bnxt.c:5337 bnxt_rx_flow_steer()
	warn: impossible condition '(new_fltr->sw_id < 0) => (0-65535 < 0)'

drivers/net/ethernet/broadcom/bnxt/bnxt.c
  5335          new_fltr->sw_id = bitmap_find_free_region(bp->ntp_fltr_bmap,
  5336                                                    BNXT_NTP_FLTR_MAX_FLTR, 0);
  5337          if (new_fltr->sw_id < 0) {
                   ^^^^^^^^^^^^^^^^^^^^
Unsigned never less than zero.

  5338                  spin_unlock_bh(&bp->ntp_fltr_lock);
  5339                  rc = -ENOMEM;
  5340                  goto err_free;
  5341          }

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-11-03 14:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-03 14:22 bnxt_en: New Broadcom ethernet driver Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).