From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: openvswitch: Fix egress tunnel info.
Date: Tue, 03 Nov 2015 14:26:23 +0000 [thread overview]
Message-ID: <20151103142623.GD28591@mwanda> (raw)
Hello Pravin B Shelar,
This is a semi-automatic email about new static checker warnings.
The patch fc4099f17240: "openvswitch: Fix egress tunnel info." from
Oct 22, 2015, leads to the following Smatch complaint:
include/net/dst_metadata.h:69 tun_dst_unclone()
warn: variable dereferenced before check 'md_dst' (see line 66)
include/net/dst_metadata.h
65 struct metadata_dst *md_dst = skb_metadata_dst(skb);
66 int md_size = md_dst->u.tun_info.options_len;
^^^^^^^^
New dereference.
67 struct metadata_dst *new_md;
68
69 if (!md_dst)
^^^^^^^
New NULL check.
70 return ERR_PTR(-EINVAL);
71
regards,
dan carpenter
reply other threads:[~2015-11-03 14:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103142623.GD28591@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).