kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* re: openvswitch: Fix egress tunnel info.
@ 2015-11-03 14:26 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2015-11-03 14:26 UTC (permalink / raw)
  To: kernel-janitors

Hello Pravin B Shelar,

This is a semi-automatic email about new static checker warnings.

The patch fc4099f17240: "openvswitch: Fix egress tunnel info." from 
Oct 22, 2015, leads to the following Smatch complaint:

include/net/dst_metadata.h:69 tun_dst_unclone()
	 warn: variable dereferenced before check 'md_dst' (see line 66)

include/net/dst_metadata.h
    65		struct metadata_dst *md_dst = skb_metadata_dst(skb);
    66		int md_size = md_dst->u.tun_info.options_len;
                              ^^^^^^^^
New dereference.

    67		struct metadata_dst *new_md;
    68	
    69		if (!md_dst)
                    ^^^^^^^
New NULL check.

    70			return ERR_PTR(-EINVAL);
    71	

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-11-03 14:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-03 14:26 openvswitch: Fix egress tunnel info Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).