Re: [PATCH] video: constify geode ops structures

Joe Perches
2015-11-10T22:39:55Z

On Wed, 2015-11-11 at 01:34 +0300, Dan Carpenter wrote:
> On Tue, Nov 10, 2015 at 02:17:12PM -0800, Joe Perches wrote:
> > On Wed, 2015-11-11 at 01:02 +0300, Dan Carpenter wrote:
> > > On Tue, Nov 10, 2015 at 12:49:29PM -0800, Joe Perches wrote:
> > > > Is there a warning/info message produced by gcc and the
> > > > plug-in when a non-const declaration is converted to
> > > > const because of this attribute?
> > >
> > > I'm not sure I understand the question. What would the warning
> > > say?
> >
> > Perhaps something like:
> >
> > declaration of struct <foo> converted to const by
> > __attribute__((do_const))
>
> No one will ever think to turn on that output. By the time they think
> of turning it on, it means they have already figured out the issue.

Dubious assertion.