From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@poochiereds.net>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] nfsd: fix a warning message
Date: Mon, 23 Nov 2015 19:05:34 +0000 [thread overview]
Message-ID: <20151123190534.GC12032@fieldses.org> (raw)
In-Reply-To: <20151122080418.65d93f86@tlielax.poochiereds.net>
On Sun, Nov 22, 2015 at 08:04:18AM -0500, Jeff Layton wrote:
> On Sat, 21 Nov 2015 13:28:50 +0300
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
Thanks, applying for 4.5.--b.
>
> > The WARN() macro takes a condition and a format string. The condition
> > was accidentally left out here so it just prints the function name
> > instead of the message.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> > index 6b800b5..7af023f 100644
> > --- a/fs/nfsd/nfs4state.c
> > +++ b/fs/nfsd/nfs4state.c
> > @@ -2240,7 +2240,8 @@ nfsd4_store_cache_entry(struct nfsd4_compoundres *resp)
> > base = resp->cstate.data_offset;
> > slot->sl_datalen = buf->len - base;
> > if (read_bytes_from_xdr_buf(buf, base, slot->sl_data, slot->sl_datalen))
> > - WARN("%s: sessions DRC could not cache compound\n", __func__);
> > + WARN(1, "%s: sessions DRC could not cache compound\n",
> > + __func__);
> > return;
> > }
> >
>
> Reviewed-by: Jeff Layton <jlayton@poochiereds.net>
prev parent reply other threads:[~2015-11-23 19:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 10:28 [patch] nfsd: fix a warning message Dan Carpenter
2015-11-22 13:04 ` Jeff Layton
2015-11-23 19:05 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123190534.GC12032@fieldses.org \
--to=bfields@fieldses.org \
--cc=dan.carpenter@oracle.com \
--cc=jlayton@poochiereds.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox