Re: [patch] OMAPDSS: DSS: fix a warning message

Tomi Valkeinen
2015-12-07T15:39:28Z

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

On 04/12/15 15:14, Dan Carpenter wrote:
> The WARN() macro has to take a condition. The current code will just
> print the stack trace and the function name instead of the intended
> warning message.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/video/fbdev/omap2/dss/dss.h b/drivers/video/fbdev/omap2/dss/dss.h
> index 2406bcd..da3a85a 100644
> --- a/drivers/video/fbdev/omap2/dss/dss.h
> +++ b/drivers/video/fbdev/omap2/dss/dss.h
> @@ -343,7 +343,8 @@ u8 dsi_get_pixel_size(enum omap_dss_dsi_pixel_format fmt);
> #else
> static inline u8 dsi_get_pixel_size(enum omap_dss_dsi_pixel_format fmt)
> {
> - WARN("%s: DSI not compiled in, returning pixel_size as 0\n", __func__);
> + WARN(1, "%s: DSI not compiled in, returning pixel_size as 0\n",
> + __func__);
> return 0;
> }
> #endif
>

Thanks, queued for 4.5.

Tomi

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]