Re: [patch RESEND] atp870u: 64 bit bug in atp885_init()

Dan Carpenter
2015-12-09T18:28:22Z

On Wed, Dec 09, 2015 at 07:11:15PM +0100, Julia Lawall wrote:
> Forgive my ignorance, but what is the exact procedure? For example, the
> following file: drivers/pcmcia/vrc4173_cardu.c contains the following
> code: INIT_WORK(&socket->tq_work, cardu_bh, socket);. The last time
> INIT_WORK took three arguments was Linux 2.6.19, so I think no one has
> been compiling this code recently. There would be the .c file and the
> associated .h file to move to staging, but it's less clear to me eg what
> to do with the Kconfig entry and the Makefile entry. And is there
> anything else to take into account?

You should just delete that code along with the Kconfig and Makefile
entries. Don't bother moving it to staging. The move to staging is
supposed to give people one last chance to yell if they absolutely need
the code. No one has compiled this code for years so no one will miss
it.

regards,
dan carpenter