From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 09 Dec 2015 18:14:20 +0000
Subject: Re: [patch] nvme: precedence bug in nvme_pr_clear()
Message-Id: <20151209181420.GB5284@mwanda>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20151209102406.GD3173@mwanda>
 <56686B55.7020900@fb.com>
In-Reply-To: <56686B55.7020900@fb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernel-janitors@vger.kernel.org

On Wed, Dec 09, 2015 at 10:56:37AM -0700, Jens Axboe wrote:
> On 12/09/2015 03:24 AM, Dan Carpenter wrote:
> >The "|" operator has higher precedence than "?:" so this didn't work as
> >intended.  I had previously fixed this bug, but it we copied the older
> >unfixed version when we moved the function between files.
> >
> >Fixes: 1673f1f08c88 ('nvme: move block_device_operations and ns/ctrl freeing to common code')
> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Dejavu, but I guess in a different function. Christoph, you are
> hereby banned from ever using ?:!

Christoph didn't write this.  I think where it went wrong is:

[Moved the integrity and pr changes due to merge conflict]

We merged the buggy version instead of the fixed version.  I don't know
git well enough to be positive.

regards,
dan carpenter