Re: [PATCH 1/1] ALSA: asihpi: Deletion of an unnecessary check before the function call "vfree"

Takashi Iwai
2014-12-02T17:39:56Z

At Tue, 02 Dec 2014 18:11:02 +0100,
SF Markus Elfring wrote:
>
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 Dec 2014 18:05:32 +0100
>
> The vfree() function performs also input parameter validation. Thus the test
> around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Applied, thanks.

Takashi

> ---
> sound/pci/asihpi/hpioctl.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/pci/asihpi/hpioctl.c b/sound/pci/asihpi/hpioctl.c
> index e457eb8..6aa677e 100644
> --- a/sound/pci/asihpi/hpioctl.c
> +++ b/sound/pci/asihpi/hpioctl.c
> @@ -547,8 +547,7 @@ void asihpi_adapter_remove(struct pci_dev *pci_dev)
> if (pa->irq)
> free_irq(pa->irq, pa);
>
> - if (pa->p_buffer)
> - vfree(pa->p_buffer);
> + vfree(pa->p_buffer);
>
> if (1)
> dev_info(&pci_dev->dev,
> --
> 2.1.3
>