Re: [PATCH 2/2] sata_mv: More error handling for phy_power_off() in mv_platform_remove()

Tejun Heo
2015-02-03T12:48:14Z

On Tue, Feb 03, 2015 at 01:32:10PM +0100, walter harms wrote:
> maybe this can be changed into
> (void) phy_power_off(hpriv->port_phys[port]);
>
> that would tell the compiler and other readers that this is intentional.

That's too anal to be helpful and too spurious to become even remotely
consistent. Things like that are actualy harmful. Note that we have
an annotation marking the other way - __must_check. Balance is to be
found towards that direction, not this, so please stop.

Thanks.

--
tejun