Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical()

Dan Carpenter
2014-11-12T22:05:40Z

On Wed, Nov 12, 2014 at 10:50:37PM +0100, SF Markus Elfring wrote:
> >> + goto cleanup1;
> >
> > 1) Don't use GW-BASIC label names. Label names should reflect what the
> > label does such as free_fuse_word or free_fuse_tabel.
> >
> > 2) Don't use do-nothing labels. Just return directly.
>
> Does the document "CodingStyle" need any extensions for special cases?

I don't understand.

> Are there any update candidates in the chapter "7: Centralized exiting of functions"?

CodingStyle says:

"If there is no cleanup needed then just return directly."

What is not clear about that?

regards,
dan carpenter