* [patch] clk: sunxi: signedness bug in sun8i_h3_bus_gates_init()
@ 2015-12-12 12:43 Dan Carpenter
2015-12-13 21:08 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-12-12 12:43 UTC (permalink / raw)
To: Emilio López, Jens Kuske
Cc: Michael Turquette, Stephen Boyd, Maxime Ripard, Chen-Yu Tsai,
linux-clk, kernel-janitors
"index" needs to be signed for the error handling to work.
Fixes: ab6e23a4e388 ('clk: sunxi: Add H3 clocks support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/clk/sunxi/clk-sun8i-bus-gates.c b/drivers/clk/sunxi/clk-sun8i-bus-gates.c
index 7ab60c5..b8c7753 100644
--- a/drivers/clk/sunxi/clk-sun8i-bus-gates.c
+++ b/drivers/clk/sunxi/clk-sun8i-bus-gates.c
@@ -40,7 +40,7 @@ static void __init sun8i_h3_bus_gates_init(struct device_node *node)
const __be32 *p;
int number, i;
u8 clk_bit;
- u32 index;
+ int index;
reg = of_io_request_and_map(node, 0, of_node_full_name(node));
if (IS_ERR(reg))
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] clk: sunxi: signedness bug in sun8i_h3_bus_gates_init()
2015-12-12 12:43 [patch] clk: sunxi: signedness bug in sun8i_h3_bus_gates_init() Dan Carpenter
@ 2015-12-13 21:08 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2015-12-13 21:08 UTC (permalink / raw)
To: Dan Carpenter
Cc: Emilio López, Jens Kuske, Michael Turquette, Stephen Boyd,
Chen-Yu Tsai, linux-clk, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 391 bytes --]
On Sat, Dec 12, 2015 at 03:43:46PM +0300, Dan Carpenter wrote:
> "index" needs to be signed for the error handling to work.
>
> Fixes: ab6e23a4e388 ('clk: sunxi: Add H3 clocks support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-13 21:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-12 12:43 [patch] clk: sunxi: signedness bug in sun8i_h3_bus_gates_init() Dan Carpenter
2015-12-13 21:08 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).