From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Sat, 19 Dec 2015 20:04:14 +0000 Subject: Re: [patch] Input: egalax: potential NULL dereference on error Message-Id: <20151219200414.GO5284@mwanda> List-Id: References: <20151219105824.GA3749@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Dmitry Torokhov , =?iso-8859-1?B?QvZzevZybelueWkgWm9sdOFu?= , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org On Sat, Dec 19, 2015 at 12:04:56PM +0100, Julia Lawall wrote: > On Sat, 19 Dec 2015, Dan Carpenter wrote: > > > We didn't check input_allocate_device() for failures so it could lead to > > a NULL deref. > > The patch does several other things... Not really. It's all part of fixing the input_allocate_device() check. regards, dan carpenter