From: Richard Cochran <richardcochran@gmail.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] posix-clock: Use an unsigned data type for a variable
Date: Sun, 20 Dec 2015 20:09:34 +0000 [thread overview]
Message-ID: <20151220200934.GB2027@netboy> (raw)
In-Reply-To: <56766488.9050402@users.sourceforge.net>
On Sun, Dec 20, 2015 at 09:19:20AM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 20 Dec 2015 09:09:34 +0100
>
> The data type "int" was used by the variable "result" in the
> function "posix_clock_poll" even though the type "uint" will usually
> be needed for the return value from a call of the function which was
> assigned to the pointer "poll" of the variable "clk".
> Reuse the type from this poll call instead.
>
> This issue was detected by using the Coccinelle software.
Coccinelle has pointed out a type mismatch. This fact may or may not
indicate a real problem. You need to analyze code to see if there is
a problem and then fix the problem.
In this case, there is indeed a problem. However, just changing the
type won't fix it.
Thanks,
Richard
next prev parent reply other threads:[~2015-12-20 20:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 8:19 [PATCH] posix-clock: Use an unsigned data type for a variable SF Markus Elfring
2015-12-20 11:09 ` Julia Lawall
2015-12-20 12:48 ` SF Markus Elfring
2015-12-20 12:51 ` Julia Lawall
2015-12-20 13:08 ` SF Markus Elfring
2015-12-20 20:09 ` Richard Cochran [this message]
2015-12-21 9:30 ` SF Markus Elfring
2015-12-21 10:12 ` Richard Cochran
2015-12-22 21:19 ` [PATCH] posix-clock: fix return code on the poll method's error path Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151220200934.GB2027@netboy \
--to=richardcochran@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox