From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Carstens Date: Mon, 04 Jan 2016 11:29:48 +0000 Subject: Re: [PATCH 1/2] 390/qeth: Delete an unnecessary variable initialisation in qeth_core_set_online() Message-Id: <20160104112948.GD4179@osiris> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5688F13A.70601@users.sourceforge.net> <5688F198.4040109@users.sourceforge.net> In-Reply-To: <5688F198.4040109@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-s390@vger.kernel.org, Martin Schwidefsky , Ursula Braun , LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Sun, Jan 03, 2016 at 11:02:00AM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 3 Jan 2016 10:48:05 +0100 > > Omit explicit initialisation at the beginning for one local variable > that is redefined before its first use. > > Signed-off-by: Markus Elfring > --- > drivers/s390/net/qeth_core_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c > index 7871537..54fde2e 100644 > --- a/drivers/s390/net/qeth_core_main.c > +++ b/drivers/s390/net/qeth_core_main.c > @@ -5637,7 +5637,7 @@ static void qeth_core_remove_device(struct ccwgroup_device *gdev) > static int qeth_core_set_online(struct ccwgroup_device *gdev) > { > struct qeth_card *card = dev_get_drvdata(&gdev->dev); > - int rc = 0; > + int rc; > int def_discipline; You can generate hundreds of patches like this one. There are even plenty more opportunities within this same file. I don't think we need this. If at all then change all occurrences within a file at once, but that is Ursula's call.