* re: mfd: PCF50633 core driver
@ 2016-01-06 10:58 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-01-06 10:58 UTC (permalink / raw)
To: kernel-janitors
Hello Balaji Rao,
The patch f52046b14b1e: "mfd: PCF50633 core driver" from Jan 9, 2009,
leads to the following static checker warning:
drivers/mfd/pcf50633-core.c:224 pcf50633_probe()
warn: 'pcf50633_reg_read(pcf, 0)()' returns unsigned values
drivers/mfd/pcf50633-core.c
221
222 version = pcf50633_reg_read(pcf, 0);
^^^^^^^^^^^^^^^^^^^^^^^^^
These return 0xFF on error, they don't return negative values.
223 variant = pcf50633_reg_read(pcf, 1);
224 if (version < 0 || variant < 0) {
225 dev_err(pcf->dev, "Unable to probe pcf50633\n");
226 ret = -ENODEV;
227 return ret;
228 }
229
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-01-06 10:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-06 10:58 mfd: PCF50633 core driver Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).