* [patch] staging: unisys: remove some dead code
@ 2016-01-07 9:34 Dan Carpenter
2016-01-07 15:47 ` Don Zickus
2016-01-12 16:26 ` Ben Romer
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-01-07 9:34 UTC (permalink / raw)
To: kernel-janitors
queue_delayed_work() returns bool, not negative error codes. It returns
false if the work has already been queued or true otherwise. Since
we don't care about that, we can just remove the test.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index 07594f4..ff2bd077 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -2310,13 +2310,8 @@ visorchipset_init(struct acpi_device *acpi_device)
}
most_recent_message_jiffies = jiffies;
poll_jiffies = POLLJIFFIES_CONTROLVMCHANNEL_FAST;
- rc = queue_delayed_work(periodic_controlvm_workqueue,
- &periodic_controlvm_work, poll_jiffies);
- if (rc < 0) {
- POSTCODE_LINUX_2(QUEUE_DELAYED_WORK_PC,
- DIAG_SEVERITY_ERR);
- goto cleanup;
- }
+ queue_delayed_work(periodic_controlvm_workqueue,
+ &periodic_controlvm_work, poll_jiffies);
visorchipset_platform_device.dev.devt = major_dev;
if (platform_device_register(&visorchipset_platform_device) < 0) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] staging: unisys: remove some dead code
2016-01-07 9:34 [patch] staging: unisys: remove some dead code Dan Carpenter
@ 2016-01-07 15:47 ` Don Zickus
2016-01-12 16:26 ` Ben Romer
1 sibling, 0 replies; 3+ messages in thread
From: Don Zickus @ 2016-01-07 15:47 UTC (permalink / raw)
To: kernel-janitors
On Thu, Jan 07, 2016 at 12:34:13PM +0300, Dan Carpenter wrote:
> queue_delayed_work() returns bool, not negative error codes. It returns
> false if the work has already been queued or true otherwise. Since
> we don't care about that, we can just remove the test.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Don Zickus <dzickus@redhat.com>
>
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
> index 07594f4..ff2bd077 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -2310,13 +2310,8 @@ visorchipset_init(struct acpi_device *acpi_device)
> }
> most_recent_message_jiffies = jiffies;
> poll_jiffies = POLLJIFFIES_CONTROLVMCHANNEL_FAST;
> - rc = queue_delayed_work(periodic_controlvm_workqueue,
> - &periodic_controlvm_work, poll_jiffies);
> - if (rc < 0) {
> - POSTCODE_LINUX_2(QUEUE_DELAYED_WORK_PC,
> - DIAG_SEVERITY_ERR);
> - goto cleanup;
> - }
> + queue_delayed_work(periodic_controlvm_workqueue,
> + &periodic_controlvm_work, poll_jiffies);
>
> visorchipset_platform_device.dev.devt = major_dev;
> if (platform_device_register(&visorchipset_platform_device) < 0) {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] staging: unisys: remove some dead code
2016-01-07 9:34 [patch] staging: unisys: remove some dead code Dan Carpenter
2016-01-07 15:47 ` Don Zickus
@ 2016-01-12 16:26 ` Ben Romer
1 sibling, 0 replies; 3+ messages in thread
From: Ben Romer @ 2016-01-12 16:26 UTC (permalink / raw)
To: kernel-janitors
On 01/07/2016 04:34 AM, Dan Carpenter wrote:
> queue_delayed_work() returns bool, not negative error codes. It returns
> false if the work has already been queued or true otherwise. Since
> we don't care about that, we can just remove the test.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Tested with s-Par, works fine (of course). :)
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-12 16:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-07 9:34 [patch] staging: unisys: remove some dead code Dan Carpenter
2016-01-07 15:47 ` Don Zickus
2016-01-12 16:26 ` Ben Romer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).