* [PATCH] rtc: rtc-ds2404: constify ds2404_chip_ops structures
@ 2015-12-30 20:59 Julia Lawall
2016-01-11 19:25 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2015-12-30 20:59 UTC (permalink / raw)
To: Alessandro Zummo
Cc: kernel-janitors, Alexandre Belloni, rtc-linux, linux-kernel
The ds2404_chip_ops structure is never modified, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/rtc/rtc-ds2404.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-ds2404.c b/drivers/rtc/rtc-ds2404.c
index 7885edd..16310fe 100644
--- a/drivers/rtc/rtc-ds2404.c
+++ b/drivers/rtc/rtc-ds2404.c
@@ -48,7 +48,7 @@ struct ds2404_gpio {
struct ds2404 {
struct ds2404_gpio *gpio;
- struct ds2404_chip_ops *ops;
+ const struct ds2404_chip_ops *ops;
struct rtc_device *rtc;
};
@@ -95,7 +95,7 @@ static void ds2404_gpio_unmap(struct ds2404 *chip)
gpio_free(ds2404_gpio[i].gpio);
}
-static struct ds2404_chip_ops ds2404_gpio_ops = {
+static const struct ds2404_chip_ops ds2404_gpio_ops = {
.map_io = ds2404_gpio_map,
.unmap_io = ds2404_gpio_unmap,
};
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] rtc: rtc-ds2404: constify ds2404_chip_ops structures
2015-12-30 20:59 [PATCH] rtc: rtc-ds2404: constify ds2404_chip_ops structures Julia Lawall
@ 2016-01-11 19:25 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2016-01-11 19:25 UTC (permalink / raw)
To: Julia Lawall; +Cc: Alessandro Zummo, kernel-janitors, rtc-linux, linux-kernel
On 30/12/2015 at 21:59:34 +0100, Julia Lawall wrote :
> The ds2404_chip_ops structure is never modified, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/rtc/rtc-ds2404.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-11 19:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-30 20:59 [PATCH] rtc: rtc-ds2404: constify ds2404_chip_ops structures Julia Lawall
2016-01-11 19:25 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).