From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: net/macb: better manage tx errors
Date: Tue, 26 Jan 2016 01:12:41 +0000 [thread overview]
Message-ID: <20160126011241.GA27064@mwanda> (raw)
Hello Nicolas Ferre,
The patch e86cd53afc59: "net/macb: better manage tx errors" from Oct
31, 2012, leads to the following static checker warning:
drivers/net/ethernet/cadence/macb.c:517 macb_halt_tx()
error: scheduling with locks held: 'spin_lock:lock'
drivers/net/ethernet/cadence/macb.c
503 static int macb_halt_tx(struct macb *bp)
504 {
505 unsigned long halt_time, timeout;
506 u32 status;
507
508 macb_writel(bp, NCR, macb_readl(bp, NCR) | MACB_BIT(THALT));
509
510 timeout = jiffies + usecs_to_jiffies(MACB_HALT_TIMEOUT);
511 do {
512 halt_time = jiffies;
513 status = macb_readl(bp, TSR);
514 if (!(status & MACB_BIT(TGO)))
515 return 0;
516
517 usleep_range(10, 250);
^^^^^^^^^^^^^^^^^^^^^
This function is called with a spinlock held so we are not allowed to
sleep.
518 } while (time_before(halt_time, timeout));
519
520 return -ETIMEDOUT;
521 }
regards,
dan carpenter
reply other threads:[~2016-01-26 1:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126011241.GA27064@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox