From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 14 Mar 2016 10:58:13 +0000 Subject: Re: [patch] kexec: potetially using uninitialized variable Message-Id: <20160314105813.GL5273@mwanda> List-Id: References: <20160311080747.GA31887@mwanda> <56E2875B.8010909@redhat.com> <20160311091919.GD5273@mwanda> <56E2944E.3030204@bfs.de> <20160311153819.GA14320@mhuang-ThinkPad-T440s> In-Reply-To: <20160311153819.GA14320@mhuang-ThinkPad-T440s> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Minfei Huang Cc: walter harms , xlpang@redhat.com, Andrew Morton , Vivek Goyal , Dave Young , Ingo Molnar , Toshi Kani , Mimi Zohar , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Fri, Mar 11, 2016 at 11:38:19PM +0800, Minfei Huang wrote: > I think we can modify the logic a bit to make code simple. Thus gcc will > not complain about any more, and the logic is earier. This is a Smatch warning, not a GCC warning. If you think the new code is clearer, that's fine but don't just silence the warning to please Smatch. I'm pretty sure I can silence this warning in Smatch. regards, dan carpenter