Re: fs-fat: Less function calls in fat_fill_super() after error detection

OGAWA Hirofumi
2014-11-29T16:08:56Z

SF Markus Elfring <elfring@users.sourceforge.net> writes:

>> More labels are more chances of bug (and we don't care micro optimize
>> on this error path), isn't it?
>
> I would prefer that a few jump targets can be redirected so that unnecessary
> function calls (and corresponding checks) can be avoided.

It is from real bugs in my experience, it saw several times those (mine
and other guys, in linux and others). And I think it doesn't have value
to maintain labels for micro optimization in *this error path* though.

So, if you or analyzer can check bugs by the patches affect to those
label usage in future,

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>