[PATCH] kprobes: Delete an unnecessary check before the function call "module_put"

SF Markus Elfring
2015-07-04T08:10:33Z

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 4 Jul 2015 10:00:26 +0200

The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
kernel/kprobes.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index c90e417..52e3529 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -1531,10 +1531,7 @@ int register_kprobe(struct kprobe *p)

out:
mutex_unlock(&kprobe_mutex);
-
- if (probed_mod)
- module_put(probed_mod);
-
+ module_put(probed_mod);
return ret;
}
EXPORT_SYMBOL_GPL(register_kprobe);
--
2.4.5