[PATCH] staging: xgifb: Delete an unnecessary check before the function call "XGIfb_search_crt2type"

SF Markus Elfring
2015-06-26T19:55:49Z

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 26 Jun 2015 21:50:41 +0200

The XGIfb_search_crt2type() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/staging/xgifb/XGI_main_26.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
index 943d463..ee0906e 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -2090,8 +2090,7 @@ static int __init xgifb_init(void)
{
char *option = NULL;

- if (forcecrt2type != NULL)
- XGIfb_search_crt2type(forcecrt2type);
+ XGIfb_search_crt2type(forcecrt2type);
if (fb_get_options("xgifb", &option))
return -ENODEV;
XGIfb_setup(option);
--
2.4.4