[PATCH 1/1] Sony-laptop: Deletion of an unnecessary check before the function call "pci_dev_put"

SF Markus Elfring
2014-11-24T21:04:16Z

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 24 Nov 2014 22:00:21 +0100

The pci_dev_put() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call
is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/platform/x86/sony-laptop.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index 26ad9ff..22b173d 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -3717,8 +3717,7 @@ static void sony_pic_detect_device_type(struct sony_pic_dev *dev)
dev->event_types = type2_events;

out:
- if (pcidev)
- pci_dev_put(pcidev);
+ pci_dev_put(pcidev);

pr_info("detected Type%d model\n",
dev->model = SONYPI_DEVICE_TYPE1 ? 1 :
--
2.1.3