Re: [PATCH] crypto-jitterentropy: Delete unnecessary checks before the function call "kzfree"

Dan Carpenter
2015-06-24T07:48:19Z

The other NULL assignment isn't useful either. Also If
"entropy_collector" is NULL then we would oops calling
kzfree(entropy_collector->mem);
^^^^^^^^^^^^^^^^^^^^^^
Dereference.

I don't understand the patch that you sent. We shouldn't be introducing
jent_zalloc() or jent_zfree(). Why are you adding abstractions there?
Quite bad ones as well.

regards,
dan carpenter