Re: [PATCH] block-rsxx: Deletion of an unnecessary check before the function call "vfree"

SF Markus Elfring
2015-06-28T11:30:13Z

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 1 Dec 2014 19:19:25 +0100
>
> The vfree() function performs also input parameter validation.
> Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/block/rsxx/dma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/rsxx/dma.c b/drivers/block/rsxx/dma.c
> index cf8cd29..0181387 100644
> --- a/drivers/block/rsxx/dma.c
> +++ b/drivers/block/rsxx/dma.c
> @@ -960,8 +960,7 @@ failed_dma_setup:
> ctrl->done_wq = NULL;
> }
>
> - if (ctrl->trackers)
> - vfree(ctrl->trackers);
> + vfree(ctrl->trackers);
>
> if (ctrl->status.buf)
> pci_free_consistent(card->dev, STATUS_BUFFER_SIZE8,
>

Would you like to integrate this update suggestion
into another source code repository?

Regards,
Markus