* [patch] ext4 crypto: fix some error handling
@ 2016-04-02 4:49 Dan Carpenter
2016-04-04 6:19 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-04-02 4:49 UTC (permalink / raw)
To: Theodore Ts'o
Cc: Andreas Dilger, linux-ext4, linux-kernel, kernel-janitors
We should be testing for -ENOMEM but the minus sign is missing.
Fixes: c9af28fdd449 ('ext4 crypto: don't let data integrity writebacks fail with ENOMEM')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
index 51b3492..b39d9c7 100644
--- a/fs/ext4/page-io.c
+++ b/fs/ext4/page-io.c
@@ -477,7 +477,7 @@ int ext4_bio_write_page(struct ext4_io_submit *io,
data_page = ext4_encrypt(inode, page, gfp_flags);
if (IS_ERR(data_page)) {
ret = PTR_ERR(data_page);
- if (ret = ENOMEM && wbc->sync_mode = WB_SYNC_ALL) {
+ if (ret = -ENOMEM && wbc->sync_mode = WB_SYNC_ALL) {
if (io->io_bio) {
ext4_io_submit(io);
congestion_wait(BLK_RW_ASYNC, HZ/50);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] ext4 crypto: fix some error handling
2016-04-02 4:49 [patch] ext4 crypto: fix some error handling Dan Carpenter
@ 2016-04-04 6:19 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2016-04-04 6:19 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Andreas Dilger, linux-ext4, linux-kernel, kernel-janitors
On Sat, Apr 02, 2016 at 07:49:16AM +0300, Dan Carpenter wrote:
> We should be testing for -ENOMEM but the minus sign is missing.
>
> Fixes: c9af28fdd449 ('ext4 crypto: don't let data integrity writebacks fail with ENOMEM')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-04 6:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-02 4:49 [patch] ext4 crypto: fix some error handling Dan Carpenter
2016-04-04 6:19 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).