From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 13 Apr 2016 17:53:57 +0000 Subject: Re: [patch] md/raid0: check for create_strip_zones() errors Message-Id: <20160413175356.GE4247@mwanda> List-Id: References: <20160413064645.GH8092@mwanda> <20160413170240.GB6186@kernel.org> In-Reply-To: <20160413170240.GB6186@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Shaohua Li Cc: Krzysztof Wojcik , linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed, Apr 13, 2016 at 10:02:40AM -0700, Shaohua Li wrote: > On Wed, Apr 13, 2016 at 09:46:45AM +0300, Dan Carpenter wrote: > > My static checker complains that if create_strip_zones() fails then we > > use "priv_conf" without initializing it. Fix this by checking for > > failure. > > It's more convenient setting '*private_conf = ERR_PTR(-ENOMEM);' at the > begining of create_strip_zones() when it returns -ENOMEM. create_strip_zones > already sets private_conf correctly in other cases. > Yeah. I'll send v2. regards, dan carpenter