From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Date: Fri, 29 Apr 2016 20:37:50 +0000 Subject: Re: [PATCH 4/5] crypto: Use dma_pool_zalloc Message-Id: <20160429223750.3a7b6849@bbrezillon> List-Id: References: <1461960552-7429-1-git-send-email-Julia.Lawall@lip6.fr> <1461960552-7429-5-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1461960552-7429-5-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, Arnaud Ebalard , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, 29 Apr 2016 22:09:11 +0200 Julia Lawall wrote: > Dma_pool_zalloc combines dma_pool_alloc and memset 0. The semantic patch > that makes this transformation is as follows: (http://coccinelle.lip6.fr/) > > // > @@ > expression d,e; > statement S; > @@ > > d > - dma_pool_alloc > + dma_pool_zalloc > (...); > if (!d) S > - memset(d, 0, sizeof(*d)); > // > > Signed-off-by: Julia Lawall Acked-by: Boris Brezillon > > --- > > drivers/crypto/marvell/tdma.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/crypto/marvell/tdma.c b/drivers/crypto/marvell/tdma.c > index 7642798..0ad8f1e 100644 > --- a/drivers/crypto/marvell/tdma.c > +++ b/drivers/crypto/marvell/tdma.c > @@ -99,12 +99,11 @@ mv_cesa_dma_add_desc(struct mv_cesa_tdma_chain *chain, gfp_t flags) > struct mv_cesa_tdma_desc *new_tdma = NULL; > dma_addr_t dma_handle; > > - new_tdma = dma_pool_alloc(cesa_dev->dma->tdma_desc_pool, flags, > - &dma_handle); > + new_tdma = dma_pool_zalloc(cesa_dev->dma->tdma_desc_pool, flags, > + &dma_handle); > if (!new_tdma) > return ERR_PTR(-ENOMEM); > > - memset(new_tdma, 0, sizeof(*new_tdma)); > new_tdma->cur_dma = dma_handle; > if (chain->last) { > chain->last->next_dma = cpu_to_le32(dma_handle); -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com