From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Date: Tue, 03 May 2016 16:18:12 +0000 Subject: Re: [patch] ASoC: hdac_hdmi: Potential NULL deref in hdac_hdmi_get_spk_alloc() Message-Id: <20160503160611.GU2274@localhost> List-Id: References: <20160503074258.GA9722@mwanda> <20160503095639.GS2274@localhost> In-Reply-To: <20160503095639.GS2274@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Liam Girdwood , "Subhransu S. Prusty" , Mark Brown , Jaroslav Kysela , Takashi Iwai , Jeeja KP , Sudip Mukherjee , Arnd Bergmann , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Sachin Mokashi , patches.audio@intel.com On Tue, May 03, 2016 at 03:26:39PM +0530, Vinod Koul wrote: > On Tue, May 03, 2016 at 10:42:58AM +0300, Dan Carpenter wrote: > > We intended || here instead of &&. The original code potentially leads > > to a NULL dereference. > > This looks good to me, I will test this and get back Acked-by: Vinod Koul Tested-by: Sachin Mokashi -- ~Vinod