From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Felipe Balbi <balbi@kernel.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] usb: dwc3: gadget: fix mask and shift order in DWC3_DCFG_NUMP()
Date: Tue, 03 May 2016 21:19:24 +0000 [thread overview]
Message-ID: <20160503211924.GB10279@kroah.com> (raw)
In-Reply-To: <87shxzfuhq.fsf@intel.com>
On Tue, May 03, 2016 at 10:53:05AM +0300, Felipe Balbi wrote:
>
> Hi,
>
> Dan Carpenter <dan.carpenter@oracle.com> writes:
> > In the original DWC3_DCFG_NUMP() was always zero. It looks like the
> > intent was to shift first and then do the mask.
> >
> > Fixes: 2a58f9c12bb3 ('usb: dwc3: gadget: disable automatic calculation of ACK TP NUMP')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thanks for this fix, I completely missed it :-) Greg, if you want to
> take this as a patch, that's fine by me. Otherwise I can queue it for
> -rc1. In any case, S-o-B below:
>
> Signed-off-by: Felipe Balbi <balbi@kernel.org>
I'll take it, thanks.
greg k-h
prev parent reply other threads:[~2016-05-03 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 7:49 [patch] usb: dwc3: gadget: fix mask and shift order in DWC3_DCFG_NUMP() Dan Carpenter
2016-05-03 7:53 ` Felipe Balbi
2016-05-03 21:19 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503211924.GB10279@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox