From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Sat, 18 Jun 2016 11:00:03 +0000 Subject: Re: [patch] ib/rxe: double free on error Message-Id: <20160618110003.GJ32247@mwanda> List-Id: References: <20160618084021.GB21713@mwanda> <20160618103430.GC5408@leon.nu> In-Reply-To: <20160618103430.GC5408-2ukJVAZIZ/Y@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Leon Romanovsky Cc: Moni Shoua , Doug Ledford , Sean Hefty , Hal Rosenstock , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Sat, Jun 18, 2016 at 01:34:30PM +0300, Leon Romanovsky wrote: > drivers/infiniband/hw/rxe/rxe.c | 29 ++++++----------------------- > 1 file changed, 6 insertions(+), 23 deletions(-) > > diff --git a/drivers/infiniband/hw/rxe/rxe.c b/drivers/infiniband/hw/rxe/rxe.c > index 48c41e00..156a1021 100644 > --- a/drivers/infiniband/hw/rxe/rxe.c > +++ b/drivers/infiniband/hw/rxe/rxe.c > @@ -165,42 +165,25 @@ static int rxe_init_port_param(struct rxe_port *port) > */ > static int rxe_init_ports(struct rxe_dev *rxe) > { > - int err; > - struct rxe_port *port; > - > - port = &rxe->port; > + struct rxe_port *port = rxe->port; This won't compile. Just give me Reported-by credit not authorship. regards, dan carpenter