From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Tue, 28 Jun 2016 15:07:56 +0000 Subject: Re: [PATCH 5/6] mfd: smsc-ece1099: Delete an unnecessary variable initialisation in smsc_i2c_probe() Message-Id: <20160628150756.GM24982@dell> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5682D228.7070902@users.sourceforge.net> <20160111082922.GB14104@x1> <05b7db2a-437a-60ac-d289-71d2150e7f5f@users.sourceforge.net> <20160608111442.GB14888@dell> <1b29f010-5617-3862-23f5-42a5e6a1bc81@users.sourceforge.net> In-Reply-To: <1b29f010-5617-3862-23f5-42a5e6a1bc81@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: SF Markus Elfring Cc: Tony Lindgren , linux-omap@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Sun, 26 Jun 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 26 Jun 2016 14:14:54 +0200 >=20 > The variable "ret" will be set to an appropriate value a bit later. > Thus omit the explicit initialisation at the beginning. >=20 > Signed-off-by: Markus Elfring > --- > drivers/mfd/smsc-ece1099.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c > index 7f89e89..2aaf89f 100644 > --- a/drivers/mfd/smsc-ece1099.c > +++ b/drivers/mfd/smsc-ece1099.c > @@ -36,7 +36,7 @@ static int smsc_i2c_probe(struct i2c_client *i2c, > { > struct smsc *smsc; > int devid, rev, venid_l, venid_h; > - int ret =3D 0; > + int ret; > =20 > smsc =3D devm_kzalloc(&i2c->dev, sizeof(struct smsc), > GFP_KERNEL); --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html