From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Tue, 28 Jun 2016 16:31:46 +0000 Subject: Re: [PATCH 4/6] mfd: dm355evm_msp: Refactoring for add_child() Message-Id: <20160628163146.GG29166@dell> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5682D228.7070902@users.sourceforge.net> <20160111082922.GB14104@x1> <05b7db2a-437a-60ac-d289-71d2150e7f5f@users.sourceforge.net> <20160608111442.GB14888@dell> <75c1cc23-3a2d-db78-d0f2-b5934b18e828@users.sourceforge.net> <20160628150725.GL24982@dell> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: SF Markus Elfring Cc: Tony Lindgren , linux-omap@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Tue, 28 Jun 2016, SF Markus Elfring wrote: > >> @@ -222,19 +222,21 @@ static struct device *add_child(struct i2c_clien= t *client, const char *name, > >> status =3D platform_device_add_resources(pdev, &r, 1); > >> if (status < 0) { > >> dev_dbg(&pdev->dev, "can't add irq\n"); > >> - goto err; > >> + goto put_device; > >> } > >> } > >> =20 > >> status =3D platform_device_add(pdev); > >> =20 > >=20 > > Remove this line too. >=20 > Do you propose the deletion of a blank line here? Yes. > Did you skip this update suggestion while the other patches were finally = accepted? I don't know what this means. The other patches in the set have been accepted. Please fix this one and send it again on its own. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html