* [patch] drm/rockchip: fix a couple off by one bugs
@ 2016-07-13 10:15 Dan Carpenter
2016-07-13 15:38 ` Sean Paul
2016-07-14 2:22 ` Mark yao
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-07-13 10:15 UTC (permalink / raw)
To: Mark Yao; +Cc: linux-rockchip, kernel-janitors, dri-devel
The priv->crtc_funcs[] array has ROCKCHIP_MAX_CRTC elements so > should
be >= here.
Fixes: 2048e3286f34 ('drm: rockchip: Add basic drm driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 7fd20c0..37ca427 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -79,7 +79,7 @@ int rockchip_register_crtc_funcs(struct drm_crtc *crtc,
int pipe = drm_crtc_index(crtc);
struct rockchip_drm_private *priv = crtc->dev->dev_private;
- if (pipe > ROCKCHIP_MAX_CRTC)
+ if (pipe >= ROCKCHIP_MAX_CRTC)
return -EINVAL;
priv->crtc_funcs[pipe] = crtc_funcs;
@@ -92,7 +92,7 @@ void rockchip_unregister_crtc_funcs(struct drm_crtc *crtc)
int pipe = drm_crtc_index(crtc);
struct rockchip_drm_private *priv = crtc->dev->dev_private;
- if (pipe > ROCKCHIP_MAX_CRTC)
+ if (pipe >= ROCKCHIP_MAX_CRTC)
return;
priv->crtc_funcs[pipe] = NULL;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] drm/rockchip: fix a couple off by one bugs
2016-07-13 10:15 [patch] drm/rockchip: fix a couple off by one bugs Dan Carpenter
@ 2016-07-13 15:38 ` Sean Paul
2016-07-14 2:22 ` Mark yao
1 sibling, 0 replies; 3+ messages in thread
From: Sean Paul @ 2016-07-13 15:38 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-rockchip, kernel-janitors, dri-devel
On Wed, Jul 13, 2016 at 3:15 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The priv->crtc_funcs[] array has ROCKCHIP_MAX_CRTC elements so > should
> be >= here.
>
> Fixes: 2048e3286f34 ('drm: rockchip: Add basic drm driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> index 7fd20c0..37ca427 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> @@ -79,7 +79,7 @@ int rockchip_register_crtc_funcs(struct drm_crtc *crtc,
> int pipe = drm_crtc_index(crtc);
> struct rockchip_drm_private *priv = crtc->dev->dev_private;
>
> - if (pipe > ROCKCHIP_MAX_CRTC)
> + if (pipe >= ROCKCHIP_MAX_CRTC)
> return -EINVAL;
>
> priv->crtc_funcs[pipe] = crtc_funcs;
> @@ -92,7 +92,7 @@ void rockchip_unregister_crtc_funcs(struct drm_crtc *crtc)
> int pipe = drm_crtc_index(crtc);
> struct rockchip_drm_private *priv = crtc->dev->dev_private;
>
> - if (pipe > ROCKCHIP_MAX_CRTC)
> + if (pipe >= ROCKCHIP_MAX_CRTC)
> return;
>
> priv->crtc_funcs[pipe] = NULL;
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] drm/rockchip: fix a couple off by one bugs
2016-07-13 10:15 [patch] drm/rockchip: fix a couple off by one bugs Dan Carpenter
2016-07-13 15:38 ` Sean Paul
@ 2016-07-14 2:22 ` Mark yao
1 sibling, 0 replies; 3+ messages in thread
From: Mark yao @ 2016-07-14 2:22 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Heiko Stuebner, dri-devel, linux-rockchip,
kernel-janitors
On 2016年07月13日 18:15, Dan Carpenter wrote:
> The priv->crtc_funcs[] array has ROCKCHIP_MAX_CRTC elements so > should
> be >= here.
>
> Fixes: 2048e3286f34 ('drm: rockchip: Add basic drm driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for the fix, applied to my drm-fixes.
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> index 7fd20c0..37ca427 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> @@ -79,7 +79,7 @@ int rockchip_register_crtc_funcs(struct drm_crtc *crtc,
> int pipe = drm_crtc_index(crtc);
> struct rockchip_drm_private *priv = crtc->dev->dev_private;
>
> - if (pipe > ROCKCHIP_MAX_CRTC)
> + if (pipe >= ROCKCHIP_MAX_CRTC)
> return -EINVAL;
>
> priv->crtc_funcs[pipe] = crtc_funcs;
> @@ -92,7 +92,7 @@ void rockchip_unregister_crtc_funcs(struct drm_crtc *crtc)
> int pipe = drm_crtc_index(crtc);
> struct rockchip_drm_private *priv = crtc->dev->dev_private;
>
> - if (pipe > ROCKCHIP_MAX_CRTC)
> + if (pipe >= ROCKCHIP_MAX_CRTC)
> return;
>
> priv->crtc_funcs[pipe] = NULL;
>
>
>
--
Ｍark Yao
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-14 2:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-13 10:15 [patch] drm/rockchip: fix a couple off by one bugs Dan Carpenter
2016-07-13 15:38 ` Sean Paul
2016-07-14 2:22 ` Mark yao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).