From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
Laura Abbott <labbott@fedoraproject.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] tools/vm/slabinfo: fix an unintentional printf
Date: Sat, 16 Jul 2016 03:34:19 +0000 [thread overview]
Message-ID: <20160716033419.GA493@swordfish> (raw)
In-Reply-To: <20160715211243.GE19522@mwanda>
On (07/16/16 00:12), Dan Carpenter wrote:
> The curly braces are missing here so we print stuff unintentionally.
>
> Fixes: 9da4714a2d4f ('slub: slabinfo update for cmpxchg handling')
Hello,
a minor correction:
it's 9da4714a2d44
not 9da4714a2d4f
-ss
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/tools/vm/slabinfo.c b/tools/vm/slabinfo.c
> index 7cf6e17..b9d34b3 100644
> --- a/tools/vm/slabinfo.c
> +++ b/tools/vm/slabinfo.c
> @@ -510,10 +510,11 @@ static void slab_stats(struct slabinfo *s)
> s->alloc_node_mismatch, (s->alloc_node_mismatch * 100) / total);
> }
>
> - if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail)
> + if (s->cmpxchg_double_fail || s->cmpxchg_double_cpu_fail) {
> printf("\nCmpxchg_double Looping\n------------------------\n");
> printf("Locked Cmpxchg Double redos %lu\nUnlocked Cmpxchg Double redos %lu\n",
> s->cmpxchg_double_fail, s->cmpxchg_double_cpu_fail);
> + }
> }
>
> static void report(struct slabinfo *s)
>
prev parent reply other threads:[~2016-07-16 3:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 21:12 [patch] tools/vm/slabinfo: fix an unintentional printf Dan Carpenter
2016-07-16 3:34 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160716033419.GA493@swordfish \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=labbott@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).