From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [bug report] x86/sfi: Enable enumeration of SD devices
Date: Tue, 09 Aug 2016 17:58:59 +0000 [thread overview]
Message-ID: <20160809175859.GF4186@mwanda> (raw)
In-Reply-To: <20160715192348.GA6521@mwanda>
On Tue, Aug 09, 2016 at 06:32:55PM +0300, Andy Shevchenko wrote:
> On Fri, 2016-07-15 at 22:23 +0300, Dan Carpenter wrote:
> > Hello Andy Shevchenko,
> >
> > The patch 05f310e26fe9: "x86/sfi: Enable enumeration of SD devices"
> > from Jul 12, 2016, leads to the following static checker warning:
> >
> > arch/x86/platform/intel-mid/sfi.c:427 sfi_handle_sd_dev()
> > warn: 'pdata' isn't an ERR_PTR
> >
> > arch/x86/platform/intel-mid/sfi.c
> > 416 memset(&sd_info, 0, sizeof(sd_info));
> > 417 strncpy(sd_info.name, pentry->name, SFI_NAME_LEN);
> > 418 sd_info.bus_num = pentry->host_num;
> > 419 sd_info.max_clk = pentry->max_freq;
> > 420 sd_info.addr = pentry->addr;
> > 421 pr_debug("SD bus = %d, name = %16.16s, max_clk = %d,
> > addr = 0x%x\n",
> > 422 sd_info.bus_num,
> > 423 sd_info.name,
> > 424 sd_info.max_clk,
> > 425 sd_info.addr);
> > 426 pdata = intel_mid_sfi_get_pdata(dev, &sd_info);
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > This is a macro calling a function pointer. None of the functions
> > return error pointers. Some return NULL on error but some return NULL
> > on success.
> >
> > 427 if (IS_ERR(pdata))
> > 428 return;
> > 429
> > 430 /* Nothing we can do with this for now */
> > 431 sd_info.platform_data = pdata;
> > 432
>
> Thanks for catching up this. At some point in the future I will re-check
> all those so called "device lib" files to be aligned to one standard. Of
> course you may propose a patch if you feel you can do it.
I'm a temporary haitus from work but what's the standard supposed
to be?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-09 17:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 19:23 [bug report] x86/sfi: Enable enumeration of SD devices Dan Carpenter
2016-08-09 15:32 ` Andy Shevchenko
2016-08-09 17:58 ` Dan Carpenter [this message]
2016-08-28 13:31 ` Andy Shevchenko
2016-08-29 20:59 ` Kuppuswamy, Sathyanarayanan
2016-08-30 9:46 ` Andy Shevchenko
2016-08-30 11:06 ` walter harms
2016-08-30 11:13 ` Andy Shevchenko
2016-08-30 18:18 ` Sathyanarayanan Kuppuswamy
2016-09-07 1:04 ` [PATCH 1/1] intel-mid: Fix sfi get_platform_data() return value issues Kuppuswamy Sathyanarayanan
2016-09-07 12:15 ` Andy Shevchenko
2016-09-08 0:04 ` sathyanarayanan kuppuswamy
2016-09-08 9:49 ` Andy Shevchenko
2016-09-08 0:05 ` [PATCH v2 " Kuppuswamy Sathyanarayanan
2016-09-08 12:51 ` Andy Shevchenko
2016-09-08 22:41 ` sathyanarayanan kuppuswamy
2016-09-09 11:20 ` Andy Shevchenko
2016-09-09 2:07 ` [PATCH v3 1/3] " Kuppuswamy Sathyanarayanan
2016-09-09 2:07 ` [PATCH v3 2/3] intel-mid: Add valid error messages on init failure Kuppuswamy Sathyanarayanan
2016-09-09 11:27 ` Andy Shevchenko
2016-09-09 2:07 ` [PATCH v3 3/3] intel-mid: Move boundry check to the start of init code Kuppuswamy Sathyanarayanan
2016-09-09 11:30 ` Andy Shevchenko
2016-09-01 13:17 ` [bug report] x86/sfi: Enable enumeration of SD devices Andy Shevchenko
2016-09-07 0:51 ` Sathyanarayanan Kuppuswamy
2016-09-07 12:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809175859.GF4186@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).