From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Date: Mon, 22 Aug 2016 13:01:15 +0000 Subject: Re: [PATCH 4/4] KVM-S390: Delete an unnecessary initialisation for a buffer variable Message-Id: <20160822150115.0fe8f20c.cornelia.huck@de.ibm.com> List-Id: References: <82b84c9c-38a4-4d17-910f-312668dbae01@users.sourceforge.net> <6cf36937-3937-0521-5f11-258f557e0c32@users.sourceforge.net> In-Reply-To: <6cf36937-3937-0521-5f11-258f557e0c32@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, Christian =?UTF-8?B?Qm9ybnRyw6RnZXI=?= , David Hildenbrand , Heiko Carstens , Martin Schwidefsky , Paolo Bonzini , Radim =?UTF-8?B?S3LEjW3DocWZ?= , LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Wed, 17 Aug 2016 20:12:15 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 17 Aug 2016 19:28:15 +0200 > > The variable "bp_data" will eventually be set to an appropriate pointer > from a call of the memdup_user() function. > Thus omit the explicit initialisation which became unnecessary with > a previous update step. > > Signed-off-by: Markus Elfring > --- > arch/s390/kvm/guestdbg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/guestdbg.c b/arch/s390/kvm/guestdbg.c > index f2514af..ad04609 100644 > --- a/arch/s390/kvm/guestdbg.c > +++ b/arch/s390/kvm/guestdbg.c > @@ -207,7 +207,7 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, > struct kvm_guest_debug *dbg) > { > int ret = 0, nr_wp = 0, nr_bp = 0, i, size; > - struct kvm_hw_breakpoint *bp_data = NULL; > + struct kvm_hw_breakpoint *bp_data; > struct kvm_hw_wp_info_arch *wp_info = NULL; > struct kvm_hw_bp_info_arch *bp_info = NULL; > NACK.