From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Date: Mon, 22 Aug 2016 13:05:32 +0000 Subject: Re: [PATCH 2/4] KVM-S390: Use memdup_user() rather than duplicating its implementation Message-Id: <20160822150532.58bd23ac.cornelia.huck@de.ibm.com> List-Id: References: <82b84c9c-38a4-4d17-910f-312668dbae01@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, Christian =?UTF-8?B?Qm9ybnRyw6RnZXI=?= , David Hildenbrand , Heiko Carstens , Martin Schwidefsky , Paolo Bonzini , Radim =?UTF-8?B?S3LEjW3DocWZ?= , LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Wed, 17 Aug 2016 20:08:49 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 17 Aug 2016 18:41:43 +0200 > > * Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > This issue was detected by using the Coccinelle software. > > * Return directly if this copy operation failed. Looks sane, but please take a bit of care about the subject: It's a bit long, and the prefix should be "KVM: s390:". > > Signed-off-by: Markus Elfring > --- > arch/s390/kvm/guestdbg.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) Acked-by: Cornelia Huck if Christian wants to apply this (unless I beat him to it).