Re: clk/Renesas-MSTP: Delete an error message for a failed memory allocation

Laurent Pinchart
2016-09-15T22:55:08Z

On Thursday 15 Sep 2016 22:17:41 SF Markus Elfring wrote:
> >>> Omit an extra message for a memory allocation failure in this function.
> >>>
> >>> Link:
> >>> http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refact
> >>> or_Strings-WSang_0.pdf
> >>>
> >>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> >>
> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > There are two other memory allocation failures printed by drivers in the
> > same directory that, you'll get my ack
>
> Does this kind of feedback express a general acceptance for the deletion
> of similar error messages?

No, it's my opinion only.

> > if you extend this patch to remove the three messages in one go.
>
> Does this wish influence the handling of suggested changes for the source
> file "drivers/clk/renesas/clk-mstp.c" anyhow?
> https://patchwork.kernel.org/patch/9332363/

Yes, please submit a new version of this patch that removes all the memory
allocation error messages from drivers/clk/renesas/ in one go.

--
Regards,

Laurent Pinchart