Re: [PATCH] checkpatch: See if modified files are marked obsolete in MAINTAINERS

Joe Perches
2016-08-22T20:56:07Z

On Mon, 2016-08-22 at 22:50 +0200, SF Markus Elfring wrote:
> > @@ -2289,6 +2299,10 @@ sub process {
> >   }
> >
> >   if ($found_file) {
> > + if (is_maintained_obsolete($realfile)) {
> > + WARN("OBSOLETE",
> > +      "$realfile is marked as 'obsolete' in the MAINTAINERS hierarchy.  No unnecessary modifications please.\n");
> > + }
> How do you think about to avoid a double negation in such a warning message?
>
> Would a wording like "… Only really necessary modifications please.\n"
> be more useful here?

No, probably not.