Re: [PATCH 2/2] ALSA: compress: Reduce the scope for two variables in snd_compr_set_params()

Joe Perches
2016-08-21T19:51:34Z

On Sun, 2016-08-21 at 21:45 +0200, SF Markus Elfring wrote:
> Reduce the scope for the local variables to an if branch.
[]
> diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
[]
> @@ -545,14 +545,14 @@ static int snd_compress_check_input(struct snd_compr_params *params)
>  static int
>  snd_compr_set_params(struct snd_compr_stream *stream, unsigned long arg)
>  {
> - struct snd_compr_params *params;
> - int retval;
> -
>   if (stream->runtime->state = SNDRV_PCM_STATE_OPEN) {

Likely better not reducing variable scope but changing:

if (stream->runtime->state = SNDRV_PCM_STATE_OPEN)

to

if (stream->runtime->state != SNDRV_PCM_STATE_OPEN)
return -EPERM;

and unindenting the remainder of the code one level instead.

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html