Re: [PATCH 2/7] iio: Rename a jump label in iio_buffer_store_watermark()

Jonathan Cameron
2016-09-24T15:32:30Z

On 24/09/16 07:25, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 24 Sep 2016 06:54:49 +0200
>
> Adjust jump labels according to the current Linux coding style convention.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
I'm not necessarily against this change which does perhaps clarify the code
ever so slightly, but I am interested to know where
'current Linux coding style convention' comes from?

Jonathan
> ---
> drivers/iio/industrialio-buffer.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
> index 7a4d9499..a865af8 100644
> --- a/drivers/iio/industrialio-buffer.c
> +++ b/drivers/iio/industrialio-buffer.c
> @@ -1028,16 +1028,16 @@ static ssize_t iio_buffer_store_watermark(struct device *dev,
>
> if (val > buffer->length) {
> ret = -EINVAL;
> - goto out;
> + goto unlock;
> }
>
> if (iio_buffer_is_active(indio_dev->buffer)) {
> ret = -EBUSY;
> - goto out;
> + goto unlock;
> }
>
> buffer->watermark = val;
> -out:
> +unlock:
> mutex_unlock(&indio_dev->mlock);
>
> return ret ? ret : len;
>