Re: [PATCH] [media] si2165: Refactoring for si2165_writereg_mask8()

Matthias Schwarzott
2016-01-04T08:39:21Z

Am 27.12.2015 um 18:33 schrieb SF Markus Elfring:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 27 Dec 2015 18:23:57 +0100
>
> This issue was detected by using the Coccinelle software.
>
> 1. Let us return directly if a call of the si2165_readreg8()
> function failed.
>
> 2. Reduce the scope for the local variables "ret" and "tmp" to one branch
> of an if statement.
>
> 3. Delete the jump label "err" then.
>
> 4. Return the value from a call of the si2165_writereg8() function
> without using an extra assignment for the variable "ret" at the end.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

The patch looks fine.

Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>

Regards
Matthias

PS: I am going to switch to regmap, but this change is not yet polished
and until now does not touch this function.