Re: [PATCH 1/2] zram: Less checks in zram_bvec_write() after error detection

SF Markus Elfring
2015-12-14T14:03:49Z

>> I suggest to make the affected exception handling a bit more efficient.
>> Such source code fine-tuning has got a few special consequences.
>
> by 'more efficient' you mean saving cpu cycles on 'bvec->bv_len != PAGE_SIZE'
> comparison in exception/error path?

Yes …

> ...
> check_strm:
> if (zstrm)
> zcomp_strm_release(zram->comp, zstrm);
> if (is_partial_io(bvec)) {
> free_uncmem:
> kfree(uncmem);
> }
> ...

I propose to jump over two sanity checks.

> no.

Thanks for your feedback.

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html