From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] mwifiex: add PCIe function level reset support
Date: Wed, 12 Oct 2016 06:18:47 +0000 [thread overview]
Message-ID: <20161012061847.GQ12841@mwanda> (raw)
Hello Amitkumar Karwar,
This is a semi-automatic email about new static checker warnings.
The patch 4c5dae59d2e9: "mwifiex: add PCIe function level reset
support" from Jul 26, 2016, leads to the following Smatch complaint:
drivers/net/wireless/marvell/mwifiex/pcie.c:3098 mwifiex_pcie_down_dev()
warn: variable dereferenced before check 'card' (see line 3090)
drivers/net/wireless/marvell/mwifiex/pcie.c
3089 struct pcie_service_card *card = adapter->card;
3090 const struct mwifiex_pcie_card_reg *reg = card->pcie.reg;
^^^^^^^^^^^^^^
New dereference.
3091
3092 if (mwifiex_write_reg(adapter, reg->drv_rdy, 0x00000000))
3093 mwifiex_dbg(adapter, ERROR, "Failed to write driver not-ready signature\n");
3094
3095 adapter->seq_num = 0;
3096 adapter->tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_4K;
3097
3098 if (card) {
^^^^
New check is too late.
3099 if (reg->sleep_cookie)
3100 mwifiex_pcie_delete_sleep_cookie_buf(adapter);
regards,
dan carpenter
reply other threads:[~2016-10-12 6:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012061847.GQ12841@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox