* [patch] staging: android/ion: testing the wrong variable
@ 2016-10-12 6:20 Dan Carpenter
2016-10-12 22:39 ` Laura Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-10-12 6:20 UTC (permalink / raw)
To: kernel-janitors
We're testing "pdev" but we intended to test "heap_pdev". This is a
static checker fix and it's unlikely that anyone is affected by this
bug.
Fixes: 13439479c7de ('staging: ion: Add files for parsing the devicetree')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
index 15bac92..46b2bb9 100644
--- a/drivers/staging/android/ion/ion_of.c
+++ b/drivers/staging/android/ion/ion_of.c
@@ -107,7 +107,7 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev,
heap_pdev = of_platform_device_create(node, heaps[i].name,
&pdev->dev);
- if (!pdev)
+ if (!heap_pdev)
return ERR_PTR(-ENOMEM);
heap_pdev->dev.platform_data = &heaps[i];
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] staging: android/ion: testing the wrong variable
2016-10-12 6:20 [patch] staging: android/ion: testing the wrong variable Dan Carpenter
@ 2016-10-12 22:39 ` Laura Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Laura Abbott @ 2016-10-12 22:39 UTC (permalink / raw)
To: kernel-janitors
On 10/11/2016 11:20 PM, Dan Carpenter wrote:
> We're testing "pdev" but we intended to test "heap_pdev". This is a
> static checker fix and it's unlikely that anyone is affected by this
> bug.
>
> Fixes: 13439479c7de ('staging: ion: Add files for parsing the devicetree')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Laura Abbott <labbott@redhat.com>
> diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
> index 15bac92..46b2bb9 100644
> --- a/drivers/staging/android/ion/ion_of.c
> +++ b/drivers/staging/android/ion/ion_of.c
> @@ -107,7 +107,7 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev,
>
> heap_pdev = of_platform_device_create(node, heaps[i].name,
> &pdev->dev);
> - if (!pdev)
> + if (!heap_pdev)
> return ERR_PTR(-ENOMEM);
> heap_pdev->dev.platform_data = &heaps[i];
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-12 22:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-12 6:20 [patch] staging: android/ion: testing the wrong variable Dan Carpenter
2016-10-12 22:39 ` Laura Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).