From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [bug report] rxrpc: Add some additional call tracing
Date: Wed, 12 Oct 2016 08:29:58 +0000 [thread overview]
Message-ID: <20161012082958.GE5630@mwanda> (raw)
In-Reply-To: <20161012061011.GH12841@mwanda>
On Wed, Oct 12, 2016 at 08:25:08AM +0100, David Howells wrote:
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > 278 trace_rxrpc_call(call, rxrpc_call_connected, atomic_read(&call->usage),
> > 279 here, ERR_PTR(ret));
> > ^^^^^^^^^^^^
> > Pointless.
>
> I guess I should just cast it instead.
It's just zero or NULL always. But if you want you can also ignore the
static checker warning since it's obviously harmless.
regards,
dan carpenter
next prev parent reply other threads:[~2016-10-12 8:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 6:10 [bug report] rxrpc: Add some additional call tracing Dan Carpenter
2016-10-12 7:25 ` David Howells
2016-10-12 8:29 ` Dan Carpenter [this message]
2016-10-12 14:59 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012082958.GE5630@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox