[patch] Staging: lustre: indent an if statement

[patch] Staging: lustre: indent an if statement

[Dan Carpenter]

This if statement wasn't intended.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
index 3199dd4..a102c36 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
@@ -335,7 +335,7 @@ int cl_object_getstripe(const struct lu_env *env, struct cl_object *obj,
 		if (obj->co_ops->coo_getstripe) {
 			result = obj->co_ops->coo_getstripe(env, obj, uarg);
 			if (result)
-			break;
+				break;
 		}
 	}
 	return result;

Re: [patch] Staging: lustre: indent an if statement

[James Simmons]

> This if statement wasn't intended.

Acked-by: James Simmons <jsimmons@infradead.org>
 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
> index 3199dd4..a102c36 100644
> --- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
> @@ -335,7 +335,7 @@ int cl_object_getstripe(const struct lu_env *env, struct cl_object *obj,
>  		if (obj->co_ops->coo_getstripe) {
>  			result = obj->co_ops->coo_getstripe(env, obj, uarg);
>  			if (result)
> -			break;
> +				break;
>  		}
>  	}
>  	return result;
> 

Re: [lustre-devel] [patch] Staging: lustre: indent an if statement

[Martin Hecht]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On 10/14/2016 12:38 AM, James Simmons wrote:
>> This if statement wasn't intended.
just to be sure: in conjunction with the subject of the mail this should
read "indented" instead of "intended", right?
- otherwise this would result in a slightly different patch...


> Acked-by: James Simmons <jsimmons@infradead.org>
>  
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
>> index 3199dd4..a102c36 100644
>> --- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
>> +++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
>> @@ -335,7 +335,7 @@ int cl_object_getstripe(const struct lu_env *env, struct cl_object *obj,
>>  		if (obj->co_ops->coo_getstripe) {
>>  			result = obj->co_ops->coo_getstripe(env, obj, uarg);
>>  			if (result)
>> -			break;
>> +				break;
>>  		}
>>  	}
>>  	return result;
>>
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 2252 bytes --]

Re: [lustre-devel] [patch] Staging: lustre: indent an if statement

[Dan Carpenter]

On Fri, Oct 14, 2016 at 12:36:25PM +0200, Martin Hecht wrote:
> On 10/14/2016 12:38 AM, James Simmons wrote:
> >> This if statement wasn't intended.
> just to be sure: in conjunction with the subject of the mail this should
> read "indented" instead of "intended", right?

Yes, yes.  I should just avoid both words from now on because my fingers
constantly get mixed up.

Greg already applied this so it's too late to send a v2.

regards,
dan carpenter