* [patch] irqchip/gicv3: fix a loop timeout
@ 2016-10-14 7:26 Dan Carpenter
2016-10-14 9:43 ` Sudeep Holla
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-10-14 7:26 UTC (permalink / raw)
To: Thomas Gleixner, Sudeep Holla
Cc: Jason Cooper, Marc Zyngier, linux-kernel, kernel-janitors
We expect the loop to exit with "count" set to zero so let's switch it
from a post-op to a pre-op count down. Otherwise we don't see the error
message when this times out.
Fixes: a2c225101234 ("irqchip: gic-v3: Refactor gic_enable_redist to support both enabling and disabling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index 9b81bd8..19d642e 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -153,7 +153,7 @@ static void gic_enable_redist(bool enable)
return; /* No PM support in this redistributor */
}
- while (count--) {
+ while (--count) {
val = readl_relaxed(rbase + GICR_WAKER);
if (enable ^ (bool)(val & GICR_WAKER_ChildrenAsleep))
break;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] irqchip/gicv3: fix a loop timeout
2016-10-14 7:26 [patch] irqchip/gicv3: fix a loop timeout Dan Carpenter
@ 2016-10-14 9:43 ` Sudeep Holla
0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2016-10-14 9:43 UTC (permalink / raw)
To: Dan Carpenter
Cc: Thomas Gleixner, Sudeep Holla, Jason Cooper, Marc Zyngier,
linux-kernel, kernel-janitors
On 14/10/16 08:26, Dan Carpenter wrote:
> We expect the loop to exit with "count" set to zero so let's switch it
> from a post-op to a pre-op count down. Otherwise we don't see the error
> message when this times out.
>
Nice catch.
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-14 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-14 7:26 [patch] irqchip/gicv3: fix a loop timeout Dan Carpenter
2016-10-14 9:43 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).