From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [bug report] staging: New driver: Xillybus generic interface for FPGA
Date: Mon, 17 Oct 2016 11:40:53 +0000 [thread overview]
Message-ID: <20161017114053.GB4469@mwanda> (raw)
In-Reply-To: <20161012082834.GA23170@mwanda>
I have read and re-read your repsonse and I can't understand it at all.
The only way this code is correct is if we take the lock when we do:
930 if (left_to_sleep > 0) {
Here we are unlocked.
931 left_to_sleep 932 wait_event_interruptible_timeout(
933 channel->wr_wait,
934 (!channel->wr_sleepy),
935 left_to_sleep);
Are you saying that here we are locked? That does NOT appear to be what
you are saying, but it is the only response that I would accept to say
that the code is correct.
In other words, the bug is probably real. Please review again.
regards,
dan carpenter
next prev parent reply other threads:[~2016-10-17 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 8:28 [bug report] staging: New driver: Xillybus generic interface for FPGA Dan Carpenter
2016-10-12 17:28 ` Eli Billauer
2016-10-17 11:40 ` Dan Carpenter [this message]
2016-10-18 4:53 ` Eli Billauer
2016-10-18 7:31 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017114053.GB4469@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox