From: Dan Carpenter <dan.carpenter@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Jiri Kosina <jikos@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: FRV-setup: Clarification for "source code clean-up"?
Date: Fri, 21 Oct 2016 09:27:30 +0000 [thread overview]
Message-ID: <20161021092730.GJ4418@mwanda> (raw)
In-Reply-To: <139f8031-4823-8de4-1a79-0af80f82cd89@users.sourceforge.net>
On Fri, Oct 21, 2016 at 11:11:54AM +0200, SF Markus Elfring wrote:
> > It's all about ratios... Each clean up patch has chance of introducing
> > a bug.
>
> Each update suggestion contains a possibility for mistakes.
>
Yes. But bug fix patches make up for it by fixing stuff.
>
> > If you only send clean up patches then you only introduce bugs.
>
> I find such a conclusion questionable with the wording "only".
>
How are you going to fix bugs if you only send clean ups?
>
> > We really don't want people sending patches if they introduce more bugs
> > than they fix.
>
> How do you think about to discuss corresponding software development
> statistics in more detail?
I think normal developers should fix 10 bugs or add a few features for
every regression they introduce. I introduced a regression just last
week, so that's a normal part of life, but I was at least *trying* to
fix a bug when I did it.
regards,
dan carpenter
next prev parent reply other threads:[~2016-10-21 9:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 5:03 [PATCH 0/6] FRV-setup: Fine-tuning for six function implementations SF Markus Elfring
2016-10-21 5:05 ` [PATCH 1/6] FRV-setup: Use seq_puts() in show_cpuinfo() SF Markus Elfring
2016-10-21 5:07 ` [PATCH 2/6] FRV-setup: Use seq_putc() " SF Markus Elfring
2016-10-21 5:08 ` [PATCH 3/6] FRV-setup: Add some spaces for better code readability SF Markus Elfring
2016-10-21 5:09 ` [PATCH 4/6] FRV-setup: Move "else" closer to a brace SF Markus Elfring
2016-10-21 5:10 ` [PATCH 5/6] FRV-setup: Fix indentation in two lines SF Markus Elfring
2016-10-21 7:24 ` Jiri Kosina
2016-10-21 7:51 ` Dan Carpenter
2016-10-21 9:11 ` FRV-setup: Clarification for "source code clean-up"? SF Markus Elfring
2016-10-21 9:27 ` Dan Carpenter [this message]
2016-10-21 9:50 ` SF Markus Elfring
2016-10-21 10:22 ` Dan Carpenter
2016-10-21 10:28 ` Geert Uytterhoeven
2016-10-21 11:03 ` Julia Lawall
2016-10-21 11:38 ` Improving software around DMA API usage? SF Markus Elfring
2016-10-21 5:11 ` [PATCH 6/6] FRV-setup: Move statements for "case" to separate lines SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021092730.GJ4418@mwanda \
--to=dan.carpenter@oracle.com \
--cc=elfring@users.sourceforge.net \
--cc=geert+renesas@glider.be \
--cc=jikos@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).