From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Date: Fri, 21 Oct 2016 09:54:35 +0000 Subject: Re: ext4: remove another test in ext4_alloc_file_blocks() Message-Id: <20161021095435.GC8271@quack2.suse.cz> List-Id: References: <20161012060002.GA12778@mwanda> In-Reply-To: <20161012060002.GA12778@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Theodore Ts'o , Fabian Frederick , Andreas Dilger , linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed 12-10-16 09:00:02, Dan Carpenter wrote: > Before commit c3fe493ccdb1 ('ext4: remove unneeded test in > ext4_alloc_file_blocks()') then it was possible for "depth" to be -1 > but now, it's not possible that it is negative. > > Signed-off-by: Dan Carpenter Looks good. You can add: Reviewed-by: Jan Kara Honza > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index c930a01..dca394c 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -4701,7 +4701,7 @@ static int ext4_alloc_file_blocks(struct file *file, ext4_lblk_t offset, > /* > * Recalculate credits when extent tree depth changes. > */ > - if (depth >= 0 && depth != ext_depth(inode)) { > + if (depth != ext_depth(inode)) { > credits = ext4_chunk_trans_blocks(inode, len); > depth = ext_depth(inode); > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Jan Kara SUSE Labs, CR