* [bug report] genetlink: fix error return code in genl_register_family()
@ 2016-11-09 9:56 Dan Carpenter
2016-11-09 22:43 ` Cong Wang
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-11-09 9:56 UTC (permalink / raw)
To: kernel-janitors
Hello Wei Yongjun,
The patch 22ca904ad70a: "genetlink: fix error return code in
genl_register_family()" from Nov 1, 2016, leads to the following
static checker warning:
net/netlink/genetlink.c:365 genl_register_family()
warn: unsigned 'family->id' is never less than zero.
net/netlink/genetlink.c
362
363 family->id = idr_alloc(&genl_fam_idr, family,
364 start, end + 1, GFP_KERNEL);
365 if (family->id < 0) {
^^^^^^^^^^^^^^
Doesn't work for unsigned int.
366 err = family->id;
367 goto errout_free;
368 }
369
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [bug report] genetlink: fix error return code in genl_register_family()
2016-11-09 9:56 [bug report] genetlink: fix error return code in genl_register_family() Dan Carpenter
@ 2016-11-09 22:43 ` Cong Wang
0 siblings, 0 replies; 2+ messages in thread
From: Cong Wang @ 2016-11-09 22:43 UTC (permalink / raw)
To: Dan Carpenter
Cc: weiyongjun1, kernel-janitors, Linux Kernel Network Developers
Cc'ing netdev
On Wed, Nov 9, 2016 at 1:56 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Hello Wei Yongjun,
>
> The patch 22ca904ad70a: "genetlink: fix error return code in
> genl_register_family()" from Nov 1, 2016, leads to the following
> static checker warning:
>
> net/netlink/genetlink.c:365 genl_register_family()
> warn: unsigned 'family->id' is never less than zero.
>
> net/netlink/genetlink.c
> 362
> 363 family->id = idr_alloc(&genl_fam_idr, family,
> 364 start, end + 1, GFP_KERNEL);
> 365 if (family->id < 0) {
> ^^^^^^^^^^^^^^
> Doesn't work for unsigned int.
family->id should be signed int.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-09 22:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-09 9:56 [bug report] genetlink: fix error return code in genl_register_family() Dan Carpenter
2016-11-09 22:43 ` Cong Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox