public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
* [bug report] ehea: Add 64bit statistics
@ 2016-11-17 13:43 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-11-17 13:43 UTC (permalink / raw)
  To: kernel-janitors

Hello Anton Blanchard,

The patch 239c562c94dc: "ehea: Add 64bit statistics" from Oct 14,
2011, leads to the following static checker warning:

	drivers/net/ethernet/ibm/ehea/ehea_main.c:3047 ehea_setup_single_port()
	warn: struct type mismatch 'rtnl_link_stats64 vs net_device_stats'

drivers/net/ethernet/ibm/ehea/ehea_main.c
  3041          INIT_WORK(&port->reset_task, ehea_reset_port);
  3042          INIT_DELAYED_WORK(&port->stats_work, ehea_update_stats);
  3043  
  3044          init_waitqueue_head(&port->swqe_avail_wq);
  3045          init_waitqueue_head(&port->restart_wq);
  3046  
  3047          memset(&port->stats, 0, sizeof(struct net_device_stats));
                                               ^^^^^^^^^^^^^^^^^^^^^^^

This should be sizeof(struct rtnl_link_stats64).  But it's harmless,
the memory starts out as zeroed.  I don't have a cross compiler set up
so I'm not going to send a patch.

  3048          ret = register_netdev(dev);
  3049          if (ret) {
  3050                  pr_err("register_netdev failed. ret=%d\n", ret);
  3051                  goto out_unreg_port;
  3052          }

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-11-17 13:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-17 13:43 [bug report] ehea: Add 64bit statistics Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox