From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
Rob Herring <robh@kernel.org>,
Krzysztof Adamski <krzysztof.adamski@tieto.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] pinctrl: sunxi: Testing the wrong variable
Date: Fri, 18 Nov 2016 13:18:13 +0000 [thread overview]
Message-ID: <20161118131813.ec4yc4azojx5cv72@lukather> (raw)
In-Reply-To: <20161118113557.GA3281@mwanda>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Fri, Nov 18, 2016 at 02:35:57PM +0300, Dan Carpenter wrote:
> Smatch complains that we dereference "map" before testing it for NULL
> which is true. We should be testing "*map" instead. Also on the error
> path, we should free *map and set it to NULL.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-11-18 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 11:35 [patch] pinctrl: sunxi: Testing the wrong variable Dan Carpenter
2016-11-18 13:18 ` Maxime Ripard [this message]
2016-11-22 8:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118131813.ec4yc4azojx5cv72@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=dan.carpenter@oracle.com \
--cc=egtvedt@samfundet.no \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzysztof.adamski@tieto.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox